desaikomal commented on code in PR #2103:
URL: https://github.com/apache/helix/pull/2103#discussion_r877292410
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java:
##########
@@ -175,10 +175,34 @@ void unsubscribeStateChanges(
void createPersistent(String path, Object data, List<ACL> acl);
+ void createPersistentWithTTL(String path, long ttl);
Review Comment:
this is not specific to your review but a generic design question.
ZK in open source will keep adding new features. As a result, do we need to
keep adding similar APIs and support?
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java:
##########
@@ -217,12 +279,23 @@ public String create(String path, Object data, CreateMode
mode) {
return create(path, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, mode);
}
+ @Override
+ public String create(String path, Object data, CreateMode mode, long ttl) {
+ return create(path, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, mode, ttl);
+ }
+
@Override
public String create(String path, Object datat, List<ACL> acl, CreateMode
mode) {
Review Comment:
Another question: how do you prevent newer ZK client talking to older
version ZK server and calling the above APIs?
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java:
##########
@@ -217,12 +279,23 @@ public String create(String path, Object data, CreateMode
mode) {
return create(path, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, mode);
}
+ @Override
+ public String create(String path, Object data, CreateMode mode, long ttl) {
+ return create(path, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, mode, ttl);
+ }
+
@Override
public String create(String path, Object datat, List<ACL> acl, CreateMode
mode) {
Review Comment:
Another question: how do you prevent newer ZK client talking to older
version ZK server and calling the above APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
