mgao0 commented on code in PR #2103:
URL: https://github.com/apache/helix/pull/2103#discussion_r877390867
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java:
##########
@@ -189,6 +189,36 @@ public void createPersistent(String path, Object data,
List<ACL> acl) {
_innerSharedZkClient.createPersistent(path, data, acl);
}
+ @Override
+ public void createPersistentWithTTL(String path, long ttl) {
Review Comment:
This comment applies to all the code below:
Why don't we call the same method with more parameters, instead we repeat
the code?
Taking this as an example, can we do `createPersistentWithTTL(path, false,
ttl)` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
