mgao0 commented on code in PR #2103:
URL: https://github.com/apache/helix/pull/2103#discussion_r877552647
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java:
##########
@@ -402,6 +478,13 @@ public Stat writeDataGetStat(String path, Object datat,
int expectedVersion) {
return _innerSharedZkClient.writeDataReturnStat(path, datat,
expectedVersion);
}
+ @Override
+ public void asyncCreate(String path, Object datat, CreateMode mode, long ttl,
+ ZkAsyncCallbacks.CreateCallbackHandler cb) {
+ checkIfPathContainsShardingKey(path);
+ _innerSharedZkClient.asyncCreate(path, datat, mode, ttl, cb);
+ }
+
@Override
public void asyncCreate(String path, Object datat, CreateMode mode,
Review Comment:
Can we use ZkClient.TTL_NOT_SET to simplify this implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
