rabashizade commented on code in PR #2103:
URL: https://github.com/apache/helix/pull/2103#discussion_r877312073
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java:
##########
@@ -217,12 +279,23 @@ public String create(String path, Object data, CreateMode
mode) {
return create(path, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, mode);
}
+ @Override
+ public String create(String path, Object data, CreateMode mode, long ttl) {
+ return create(path, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, mode, ttl);
+ }
+
@Override
public String create(String path, Object datat, List<ACL> acl, CreateMode
mode) {
Review Comment:
This is a good question, we can't really prevent them because we have no way
of knowing the ZK's version, but ZK itself (whether older version or newer
version without the extended types enabled as explained
[here](https://zookeeper.apache.org/doc/current/zookeeperAdmin.html#sc_configuration))
will throw a `KeeperException.UnimplementedException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
