Marcosrico commented on code in PR #2201:
URL: https://github.com/apache/helix/pull/2201#discussion_r964124311
##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java:
##########
@@ -433,6 +433,36 @@ public void testSyncRemove() {
System.out.println("END " + testName + " at " + new
Date(System.currentTimeMillis()));
}
+ @Test
+ public void testDeleteLogging() {
+ String root = _rootPath;
+
+ ZkBaseDataAccessor<ZNRecord> accessor = new
ZkBaseDataAccessor<>(_gZkClient);
Review Comment:
I might have phrased my answer wrong. The test does check whether zk catches
the error of removing a parent node with children, which I believe is not
tested elsewhere, though not sure if that is considered as delete
functionality. The primary motive for the test is to catch this error and make
sure the right logging is made. Perhaps that is not necessary given the
variable nature of log configs - let me know, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
