Marcosrico commented on code in PR #2201:
URL: https://github.com/apache/helix/pull/2201#discussion_r965032828
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java:
##########
@@ -726,7 +726,7 @@ public boolean remove(String path, int options) {
// case, we try to delete recursively
_zkClient.delete(path);
} catch (ZkException e) {
- LOG.debug("Failed to delete {} with opts {}, err: {}. Try recursive
delete", path, options,
+ LOG.info("Failed to delete {} with opts {}, err: {}. Try recursive
delete", path, options,
Review Comment:
I am not too familiar with what the default logging is for the different
applications of these methods. However, the ticket and issue created arose from
customers (i.e. Venice) who have run into the issue of these "noisy" logs.
Ideally, we would want to completely avoid calling these logs altogether (in
the case that deletion succeeds further on). However, we weren't able to come
up with a liable solution. Thus, if the log error is to be shown regardless,
the purpose of this change as Xiaoyuan mentioned is to make it less misleading.
Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
