qqu0127 commented on code in PR #2201:
URL: https://github.com/apache/helix/pull/2201#discussion_r964145532
##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java:
##########
@@ -433,6 +433,36 @@ public void testSyncRemove() {
System.out.println("END " + testName + " at " + new
Date(System.currentTimeMillis()));
}
+ @Test
+ public void testDeleteLogging() {
+ String root = _rootPath;
+
+ ZkBaseDataAccessor<ZNRecord> accessor = new
ZkBaseDataAccessor<>(_gZkClient);
Review Comment:
Ok, I see your point. My concern is that, `"make sure the right logging is
made"` is checked manually. It doesn't add much value to the unit test in
regard to logging. Functionally, it does have value to verify no exception is
thrown. So we may keep the test, and rename it to e.g.
`testDeleteNodeWithChildren`, just my two cents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
