desaikomal commented on code in PR #2661:
URL: https://github.com/apache/helix/pull/2661#discussion_r1373332538
##########
helix-core/src/main/java/org/apache/helix/HelixAdmin.java:
##########
@@ -747,6 +756,26 @@ Map<String, Boolean>
validateInstancesForWagedRebalance(String clusterName,
*/
boolean isEvacuateFinished(String clusterName, String instancesNames);
+ /**
+ * Check to see if swapping between two instances can be completed. Either
the swapOut or
+ * swapIn instance can be passed in.
+ * @param clusterName The cluster name
+ * @param instanceName The instance that is being swapped out or swapped in
+ * @return True if the swap is ready to be completed, false otherwise.
Review Comment:
sorry for my lack of understanding, typically swap involves 2 entries, why
does the API take only one? Also what does "swap" mean in this context?
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -858,6 +886,42 @@ private void
updateDisabledInstances(Collection<InstanceConfig> instanceConfigs,
}
}
+ private void updateSwappingInstances(Collection<InstanceConfig>
instanceConfigs,
Review Comment:
do we need to make sure only one thread executes this?
as you are completely cleaning out? what happens to things which are
in-progress?
##########
helix-core/src/main/java/org/apache/helix/HelixAdmin.java:
##########
@@ -747,6 +756,26 @@ Map<String, Boolean>
validateInstancesForWagedRebalance(String clusterName,
*/
boolean isEvacuateFinished(String clusterName, String instancesNames);
+ /**
+ * Check to see if swapping between two instances can be completed. Either
the swapOut or
+ * swapIn instance can be passed in.
+ * @param clusterName The cluster name
+ * @param instanceName The instance that is being swapped out or swapped in
+ * @return True if the swap is ready to be completed, false otherwise.
Review Comment:
unless instanceName is like "virtual" and there are 2 entities tied to the
same virtual instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
