zpinto commented on code in PR #2661:
URL: https://github.com/apache/helix/pull/2661#discussion_r1373739028
##########
helix-core/src/main/java/org/apache/helix/HelixAdmin.java:
##########
@@ -747,6 +756,26 @@ Map<String, Boolean>
validateInstancesForWagedRebalance(String clusterName,
*/
boolean isEvacuateFinished(String clusterName, String instancesNames);
+ /**
+ * Check to see if swapping between two instances can be completed. Either
the swapOut or
+ * swapIn instance can be passed in.
+ * @param clusterName The cluster name
+ * @param instanceName The instance that is being swapped out or swapped in
+ * @return True if the swap is ready to be completed, false otherwise.
Review Comment:
Instance name in this case will be one of the unique instance names(same as
InstanceConfig znode ID) involved in the swap. Either SWAP_OUT or SWAP_IN. This
API is intended to be used with the PerInstanceAccessor in helix-rest. For that
endpoint you pass one instanceName.
Because we can find the matching swap instance for either SWAP_OUT or
SWAP_IN node, we can take either as the instance name.
"swap" is referring to the operation between two instances which can be
deduced from providing one of the instances involved in the swap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
