himanshukandwal commented on code in PR #2661:
URL: https://github.com/apache/helix/pull/2661#discussion_r1373745155
##########
helix-core/src/main/java/org/apache/helix/HelixAdmin.java:
##########
@@ -747,6 +756,26 @@ Map<String, Boolean>
validateInstancesForWagedRebalance(String clusterName,
*/
boolean isEvacuateFinished(String clusterName, String instancesNames);
+ /**
+ * Check to see if swapping between two instances can be completed. Either
the swapOut or
+ * swapIn instance can be passed in.
+ * @param clusterName The cluster name
+ * @param instanceName The instance that is being swapped out or swapped in
+ * @return True if the swap is ready to be completed, false otherwise.
+ */
+ boolean canSwapBeCompleted(String clusterName, String instanceName);
Review Comment:
maybe: `canCompleteSwap`
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PerInstanceAccessor.java:
##########
@@ -435,6 +435,11 @@ public Response updateInstance(@PathParam("clusterId")
String clusterId,
case setInstanceOperation:
admin.setInstanceOperation(clusterId, instanceName, state);
break;
+ case completeSwapIfPossible:
Review Comment:
nit: indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
