zpinto commented on code in PR #2661:
URL: https://github.com/apache/helix/pull/2661#discussion_r1373814365
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -858,6 +886,42 @@ private void
updateDisabledInstances(Collection<InstanceConfig> instanceConfigs,
}
}
+ private void updateSwappingInstances(Collection<InstanceConfig>
instanceConfigs,
Review Comment:
The assumption is that the if the instance is added with the same logicalId
as an existing instance, it should meet the criteria of having the same zone
and capacity. We ca definitely add a check to fail early if trying to
`addInstance` without adhering to the swap requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
