MarkGaox commented on code in PR #2680:
URL: https://github.com/apache/helix/pull/2680#discussion_r1374861142
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java:
##########
@@ -339,17 +339,17 @@ private List<OperationInterface>
getAllOperationClasses(List<String> operations)
*/
public StoppableCheck getInstanceStoppableCheck(String clusterId, String
instanceName,
String jsonContent) throws IOException {
- return batchGetInstancesStoppableChecks(clusterId,
ImmutableList.of(instanceName), jsonContent)
+ return batchGetInstancesStoppableChecks(clusterId,
ImmutableList.of(instanceName), jsonContent, Collections.emptySet())
.get(instanceName);
}
public Map<String, StoppableCheck> batchGetInstancesStoppableChecks(String
clusterId,
- List<String> instances, String jsonContent) throws IOException {
+ List<String> instances, String jsonContent, Set<String>
toBeStoppedInstances) throws IOException {
Review Comment:
Added a new method `public Map<String, StoppableCheck>
batchGetInstancesStoppableChecks(String clusterId,
List<String> instances, String jsonContent)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
