MarkGaox commented on code in PR #2680:
URL: https://github.com/apache/helix/pull/2680#discussion_r1374902414
##########
helix-rest/src/test/java/org/apache/helix/rest/clusterMaintenanceService/TestMaintenanceManagementService.java:
##########
@@ -114,7 +114,7 @@ public MockMaintenanceManagementService(ZKHelixDataAccessor
dataAccessor,
@Override
protected Map<String, Boolean> getInstanceHealthStatus(String clusterId,
String instanceName,
- List<HealthCheck> healthChecks) {
+ List<HealthCheck> healthChecks, Set<String> toBeStoppedInstances) {
Review Comment:
The reason why we still need to change this override is the
`getInstanceStoppableCheck` will eventually call `protected Map<String,
Boolean> getInstanceHealthStatus(String clusterId, String instanceName,
List<HealthCheck> healthChecks, Set<String> toBeStoppedInstances) `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
