zpinto commented on code in PR #2680:
URL: https://github.com/apache/helix/pull/2680#discussion_r1374976021
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/StoppableInstancesSelector.java:
##########
@@ -99,13 +121,15 @@ public void getStoppableInstancesCrossZones(List<String>
instances,
if (instanceSet.isEmpty()) {
continue;
}
- getStoppableInstances(new ArrayList<>(instanceSet),
toBeStoppedInstances);
+ getStoppableInstances(new ArrayList<>(instanceSet),
toBeStoppedInstancesSet, stoppableInstances,
+ failedStoppableInstances);
}
- processNonexistentInstances(instances);
+ processNonexistentInstances(instances, failedStoppableInstances);
+ return result;
}
- private void getStoppableInstances(List<String> instances, Set<String>
toBeStoppedInstances)
- throws IOException {
+ private void getStoppableInstances(List<String> instances, Set<String>
toBeStoppedInstances,
Review Comment:
nit: I would call this `populateStoppableInstances` or something along those
lines since this method has side effect of modifying a list that is passed by
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
