junkaixue commented on code in PR #2696:
URL: https://github.com/apache/helix/pull/2696#discussion_r1419689225
##########
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java:
##########
@@ -488,11 +490,11 @@ public boolean scheduleTask(MessageTask task) {
"Message handling task already sheduled for " + taskId, manager);
}
}
- } catch (Exception e) {
+ } catch (Throwable e) {
Review Comment:
In Helix, we use general Exception instead of Throwable. Even Throwable, you
need to replace variable name to t.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
