xyuanlu commented on code in PR #2696:
URL: https://github.com/apache/helix/pull/2696#discussion_r1446415403
##########
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java:
##########
@@ -488,10 +490,10 @@ public boolean scheduleTask(MessageTask task) {
"Message handling task already sheduled for " + taskId, manager);
}
}
- } catch (Exception e) {
- LOG.error("Error while executing task. " + message, e);
+ } catch (Throwable t) {
+ LOG.error("Error while executing task. " + message, t);
_statusUpdateUtil
- .logError(message, HelixTaskExecutor.class, e, "Error while
executing task " + e,
+ .logError(message, HelixTaskExecutor.class, "Error while executing
task " + t,
Review Comment:
Please consider not integrate the Throwable in message. If we do it this
way, it only print out a short description of this throwable.
We may want to print the stack trace and other information. Please consider
something like.
```
public void logError(Message message, Class classInfo, Exception e, String
additionalInfo,
HelixManager manager)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
