desaikomal commented on PR #2739: URL: https://github.com/apache/helix/pull/2739#issuecomment-1894918603
First and foremost, excellent debugging. QQ: After investigation, it was found that the offlineTimeMap was not being cleared by the cache and the BEST_POSSIBLE_STATE was not being persisted to ZK each time a new version was being computed by partial rebalance. Fixing these two issues ensures that the pipeline produces the correct finalMapping and the partitionAssignmentAPI is not using a stale BEST_POSSIBLE_STATE to compute the simulated finalMapping. I understand the second part, very well. You removed '_assignableDisabledInstanceSet' - how does it relate to the analysis? for first part, the problem was happening only when we have certain hosts crossing over the delayed window? so essentially global pipeline gets updated, but partial pipeline is not persisted, so we get results are different? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
