zpinto commented on code in PR #2739:
URL: https://github.com/apache/helix/pull/2739#discussion_r1456611251
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/AssignmentMetadataStore.java:
##########
@@ -52,6 +52,7 @@ public class AssignmentMetadataStore {
protected volatile Map<String, ResourceAssignment> _globalBaseline;
protected volatile Map<String, ResourceAssignment> _bestPossibleAssignment;
protected volatile int _bestPossibleVersion = 0;
+ protected volatile int _lastPersistedBestPossibleVersion = 0;
Review Comment:
In order to do this, we would have to add a public method to
BucketDataAccessor interface. This will cause a backwards incompatible change.
Let's hold off on this for now, as the actual version does not matter in the
context of the AssignmentMetadataStore object. The use of version here is local
to the controller thread processing the pipeline for the cluster. We only need
to maintain version here to make sure we flush the cache to ZK eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
