desaikomal commented on code in PR #2739:
URL: https://github.com/apache/helix/pull/2739#discussion_r1454550417
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -552,7 +551,6 @@ protected synchronized Set<HelixConstants.ChangeType>
doRefresh(HelixDataAccesso
updateIdealRuleMap(getClusterConfig());
updateDisabledInstances(getInstanceConfigMap().values(),
Review Comment:
this is the cache which required update?
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/AssignmentMetadataStore.java:
##########
@@ -76,6 +77,10 @@ public Map<String, ResourceAssignment> getBaseline() {
return _globalBaseline;
}
+ public boolean hasPersistedLatestBestPossibleAssignment() {
Review Comment:
can you add detail as to why we need this variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
