zpinto commented on code in PR #2739:
URL: https://github.com/apache/helix/pull/2739#discussion_r1456527814
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -552,7 +551,6 @@ protected synchronized Set<HelixConstants.ChangeType>
doRefresh(HelixDataAccesso
updateIdealRuleMap(getClusterConfig());
updateDisabledInstances(getInstanceConfigMap().values(),
Review Comment:
Yes, in node swap cache changes we introduced
`_assignableDisabledInstanceSet`. We were not clearing it on cache refresh.
This would lead WagedCapacityProvider to not charge pending messages against
the instances capacity for any instance that was offline at some point.
After revising, this cache is not necessary as we can use
`_disabledInstanceSet` to determine enabled instances and enabled assignable
instances since it will be a superset of `_assignableDisabledInstanceSet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
