zpinto commented on code in PR #2772:
URL: https://github.com/apache/helix/pull/2772#discussion_r1546850779
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -1127,7 +1066,7 @@ private void
updateDisabledInstances(Collection<InstanceConfig> allInstanceConfi
_disabledInstanceSet.clear();
for (InstanceConfig config : allInstanceConfigs) {
Map<String, List<String>> disabledPartitionMap =
config.getDisabledPartitionsMap();
- if (!InstanceValidationUtil.isInstanceEnabled(config, clusterConfig)) {
+ if
(config.getInstanceOperation().equals(InstanceConstants.InstanceOperation.DISABLE))
{
Review Comment:
I think we should remove `InstanceValidationUtil.isInstanceEnabled` all
together since that method is just calling isInstanceEnabled and skipping the
logic for checking if instance is in DISABLED_INSTANCES of cluster config.
Also, controller can no longer just say `!config.isInstanceEnabled` since
there are more states to consider than just ENABLE and DISABLE. We need to
check if the InstanceOperation is equal to DISABLE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
