zpinto commented on code in PR #2772:
URL: https://github.com/apache/helix/pull/2772#discussion_r1548994218
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -1127,7 +1066,7 @@ private void
updateDisabledInstances(Collection<InstanceConfig> allInstanceConfi
_disabledInstanceSet.clear();
for (InstanceConfig config : allInstanceConfigs) {
Map<String, List<String>> disabledPartitionMap =
config.getDisabledPartitionsMap();
- if (!InstanceValidationUtil.isInstanceEnabled(config, clusterConfig)) {
+ if
(config.getInstanceOperation().equals(InstanceConstants.InstanceOperation.DISABLE))
{
Review Comment:
I have deprecated `InstanceValidationUtil.isInstanceEnabled` and fields for
disabling instances in ClusterConfig. We will move away from that as it isn't
being used currently and does not align with future plans for InstanceOperation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
