zpinto commented on code in PR #2772:
URL: https://github.com/apache/helix/pull/2772#discussion_r1548990072
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java:
##########
@@ -363,6 +364,9 @@ protected Map<String, String>
computeBestPossibleStateForPartition(Set<String> l
currentMapWithPreferenceList.keySet().retainAll(preferenceList);
combinedPreferenceList.addAll(currentInstances);
+ if (cache != null) {
+ combinedPreferenceList.removeAll(cache.getUnknownInstances());
+ }
Review Comment:
I removed this and now pass in a current state that excludes UNKNOWN
instances. This current state is generated in CurrentStateComputationStage and
is added as another cluster event attribute called
CURRENT_STATE_EXCLUDING_UNKNOWN. This will ensure that there is not n -> n+1
for UNKNOWN InstanceOperation.
I have also changed MessageGenerationStage to drop replicas that are in
current state and not in BestPossibleState instanceStateMaps so that we will be
able to drop when setting to UNKNOWN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
