zpinto commented on code in PR #2772:
URL: https://github.com/apache/helix/pull/2772#discussion_r1548620258


##########
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java:
##########
@@ -302,13 +310,14 @@ public void setInstanceDisabledReason(String 
disabledReason) {
    * It will be a no-op when instance is enabled.
    */
   public void setInstanceDisabledType(InstanceConstants.InstanceDisabledType 
disabledType) {

Review Comment:
   I agree that we need to build a more generic API for more than just the 
DISABLE InstanceOperation. We will open a future PR with this change, as the 
disable type, disable reason, etc. needs to be rethought completely. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to