Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8611 )

Change subject: IMPALA-6225: Query profile date-time strings should have ns 
precision.
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py@133
PS6, Line 133: time.time() - start_time < 120
May be a counter here is sufficient as we have sleep below.


http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py@149
PS6, Line 149: if len(start_time_sub_sec_str) == 0 or len(end_time_sub_sec_str) 
== 0:
The test will fail at this point anyway so may as well do what Phil suggested 
plus printing out the start_time_sub-sec_str and end_time_sub_sec_str in case 
only one of them is available.

line 152-153 are not needed in this case.



--
To view, visit http://gerrit.cloudera.org:8080/8611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0
Gerrit-Change-Number: 8611
Gerrit-PatchSet: 6
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Nov 2017 00:20:41 +0000
Gerrit-HasComments: Yes

Reply via email to