Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )
Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. ...................................................................... Patch Set 6: (4 comments) Uploading patch #7. http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py@133 PS6, Line 133: time.time() - start_time < 120 > May be a counter here is sufficient as we have sleep below. Now using a retry counter instead. http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py@149 PS6, Line 149: if len(start_time_sub_sec_str) == 0 or len(end_time_sub_sec_str) == 0: > The test will fail at this point anyway so may as well do what Phil suggest Done http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py@151 PS6, Line 151: print 'Test case will fail' > I think the following will fail more obviously: Done http://gerrit.cloudera.org:8080/#/c/8611/6/tests/query_test/test_observability.py@152 PS6, Line 152: assert len(start_time_sub_sec_str) == 9 > I don't think this line is ever reached, because in the successful case, li Removed these lines. -- To view, visit http://gerrit.cloudera.org:8080/8611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0 Gerrit-Change-Number: 8611 Gerrit-PatchSet: 6 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 00:33:01 +0000 Gerrit-HasComments: Yes
