Michael Ho has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8788


Change subject: IMPALA-6285: Don't print stack trace on RPC errors.
......................................................................

IMPALA-6285: Don't print stack trace on RPC errors.

There is not much benefit in printing the stack trace when
Thrift RPC hits an error. As long as we print enough info about
the error and idetify the caller, that should be sufficient.
In fact, it has been observed that stack crawl caused unnecessary
CPU spikes in the past. This change replaces Status() with
Status::Expected() in DoRpc(), RetryRpc() and RetryRpcRecv() to
avoid unnecessary stack crawls.

Testing done: private core build.

Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58
---
M be/src/exec/catalog-op-executor.cc
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/data-stream-sender.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/service/client-request-state.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
10 files changed, 65 insertions(+), 42 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/8788/1
--
To view, visit http://gerrit.cloudera.org:8080/8788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58
Gerrit-Change-Number: 8788
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <k...@cloudera.com>

Reply via email to