Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8788 )

Change subject: IMPALA-6285: Don't print stack trace on RPC errors.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h
File be/src/runtime/client-cache.h:

http://gerrit.cloudera.org:8080/#/c/8788/2/be/src/runtime/client-cache.h@328
PS2, Line 328:       ErrorMsg msg(TErrorCode::RPC_CLIENT_CONNECT_FAILURE, 
status.GetDetail());
             :       VLOG_QUERY << msg.msg() << " rpc: " << 
typeid(*response).name();
             :       return Status::Expected(msg);
> Create a ClientConnectFailureStatus() function too just to keep it consiste
Seems unnecessary given there is only one place using it.



--
To view, visit http://gerrit.cloudera.org:8080/8788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58
Gerrit-Change-Number: 8788
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 16:56:43 +0000
Gerrit-HasComments: Yes

Reply via email to