Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 )
Change subject: IMPALA-6285: Don't print stack trace on RPC errors. ...................................................................... Patch Set 2: (2 comments) The output messages were confirmed with tests/custom_cluster/test_rpc_exception.py and tests/custom_cluster/test_rpc_timeout.py http://gerrit.cloudera.org:8080/#/c/8788/1/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/8788/1/be/src/exec/catalog-op-executor.cc@279 PS1, Line 279: client.DoRpc(&CatalogServiceClientWrapper::GetCatalogObject, request, &response)); > We probably frown upon it, but it may be that typeId(request) inside of DoR Actually, that's a good idea. We are doing that already for the exception type string. http://gerrit.cloudera.org:8080/#/c/8788/1/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: http://gerrit.cloudera.org:8080/#/c/8788/1/be/src/runtime/client-cache.h@298 PS1, Line 298: Status GeneralErrorStatus( > nit: "Function for" can be removed (and tenses changed slightly); also in l Done -- To view, visit http://gerrit.cloudera.org:8080/8788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 Gerrit-Change-Number: 8788 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 07 Dec 2017 08:30:59 +0000 Gerrit-HasComments: Yes
