Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 )
Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module ...................................................................... Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen-test.cc@111 PS11, Line 111: for(auto fn : codegen->handcrafted_functions_){ : if(fn == function) return true; : } : return false; > const auto& hf = codegen->handcrafted_functions_; Done http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen-test.cc@498 PS11, Line 498: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen-test.cc@506 PS11, Line 506: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen-test.cc@507 PS11, Line 507: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen.h@228 PS11, Line 228: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen.h@228 PS11, Line 228: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8541/11/be/src/codegen/llvm-codegen.cc@182 PS11, Line 182: NULL > nullptr Done -- To view, visit http://gerrit.cloudera.org:8080/8541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f Gerrit-Change-Number: 8541 Gerrit-PatchSet: 11 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 19 Dec 2017 21:44:37 +0000 Gerrit-HasComments: Yes
