Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8852 )

Change subject: IMPALA-6318: Adjustment for hanging query cancellation test
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/8852/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8852/1//COMMIT_MSG@18
PS1, Line 18: ImpalaShel
> the ImpalaShell process?
Done


http://gerrit.cloudera.org:8080/#/c/8852/1//COMMIT_MSG@19
PS1, Line 19: new option
> optional parameter to
Done


http://gerrit.cloudera.org:8080/#/c/8852/1//COMMIT_MSG@20
PS1, Line 20: util.ImpalaShell
> util.ImpalaShell
Done


http://gerrit.cloudera.org:8080/#/c/8852/1/tests/shell/util.py
File tests/shell/util.py:

http://gerrit.cloudera.org:8080/#/c/8852/1/tests/shell/util.py@133
PS1, Line 133: s
> nit: proces -> process
Done


http://gerrit.cloudera.org:8080/#/c/8852/1/tests/shell/util.py@168
PS1, Line 168: stdout = None if omit_stdout else PIPE
             :     return Popen(lex, shell=False, stdout=stdout, stdin=PIPE, 
stderr=PIPE,
             :                  en
> stdout = None if omit_std_out else PIPE
Done



--
To view, visit http://gerrit.cloudera.org:8080/8852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c83b91b6d0c527de92c7992f0dc9d1b290433
Gerrit-Change-Number: 8852
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 15 Dec 2017 11:54:49 +0000
Gerrit-HasComments: Yes

Reply via email to