Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 )
Change subject: IMPALA-6318: Adjustment for hanging query cancellation test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8852/3/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/8852/3/tests/shell/util.py@168 PS3, Line 168: stdout = None if omit_stdout else PIPE Looking at the Popen docs, I think this means that stdout gets sent to the stdout of the current process, which I think means that we're capturing it as part of the test output. Is this what we want? -- To view, visit http://gerrit.cloudera.org:8080/8852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I082c83b91b6d0c527de92c7992f0dc9d1b290433 Gerrit-Change-Number: 8852 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2017 16:28:25 +0000 Gerrit-HasComments: Yes
