Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 )
Change subject: IMPALA-6386: Invalidate metadata at table level for dataload ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9009/1/bin/load-data.py File bin/load-data.py: http://gerrit.cloudera.org:8080/#/c/9009/1/bin/load-data.py@318 PS1, Line 318: create_filename = 'load-%s-impala-generated' % load_file_substr > create_filename = 'load' The '%s-impala-generated' currently matches files like 'load-functional-query-exhaustive-impala-generated-avro-def-block.sql'. It is matching by asking if create_filename is in the filename. So, this match works, but '%s-impala-generated' (filled in => 'functional-query-exhaustive-impala-generated') is not particularly specific. Right now, we don't have any other filenames of this form, but my new 'invalidate-%s-impala-generated.sql' files match this condition. So, to distinguish between the invalidate file and the preexisting files, I need to make the condition more exact. The file names are bad. I'll look into renaming some things. -- To view, visit http://gerrit.cloudera.org:8080/9009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3a6d8a674a0bf6b02069bfe8a5e12034335b1f Gerrit-Change-Number: 9009 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 12 Jan 2018 00:16:27 +0000 Gerrit-HasComments: Yes
