Zach Amsden has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9009 )

Change subject: IMPALA-6386: Invalidate metadata at table level for dataload
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9009/1/bin/load-data.py
File bin/load-data.py:

http://gerrit.cloudera.org:8080/#/c/9009/1/bin/load-data.py@318
PS1, Line 318:     create_filename = 'load-%s-impala-generated' % 
load_file_substr
> The '%s-impala-generated' currently matches files like 'load-functional-que
This isn't your fault, but it seems particularly fragile that we have to 
generate identical filenames in multiple pieces of python code.



--
To view, visit http://gerrit.cloudera.org:8080/9009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc3a6d8a674a0bf6b02069bfe8a5e12034335b1f
Gerrit-Change-Number: 9009
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
Gerrit-Comment-Date: Fri, 12 Jan 2018 00:24:03 +0000
Gerrit-HasComments: Yes

Reply via email to