Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 )
Change subject: IMPALA-6386: Invalidate metadata at table level for dataload ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9009/1/bin/load-data.py File bin/load-data.py: http://gerrit.cloudera.org:8080/#/c/9009/1/bin/load-data.py@318 PS1, Line 318: create_filename = 'load-%s-impala-generated' % load_file_substr > This isn't your fault, but it seems particularly fragile that we have to ge I agree. The SQL generation should also generate a dependency graph, which should drive execution. Arbitrary filenames are a bad interface. I'm fixing the filenames so that create statements are in a create-%s-impala-generated and load is in a load-%s-impala-generated. This makes it a bit less weird. -- To view, visit http://gerrit.cloudera.org:8080/9009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc3a6d8a674a0bf6b02069bfe8a5e12034335b1f Gerrit-Change-Number: 9009 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 12 Jan 2018 00:43:34 +0000 Gerrit-HasComments: Yes
