Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9009 )

Change subject: IMPALA-6386: Invalidate metadata at table level for dataload
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9009/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/9009/2/testdata/bin/generate-schema-statements.py@492
PS2, Line 492:     impala_output = Statements()
> Maybe s/impala_output/impala_create/g
Done


http://gerrit.cloudera.org:8080/#/c/9009/2/testdata/bin/generate-schema-statements.py@702
PS2, Line 702:   hive_output.write_to_file('load-' + output_name + 
'-hive-generated.sql')
> Ideally these names should match as well (hive_load, hbase_load), but it is
I'm going to skip this. hive_output incorporates a mix of create, load, and 
other things. This will get a bit cleaner when we do parallel Hive.



--
To view, visit http://gerrit.cloudera.org:8080/9009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc3a6d8a674a0bf6b02069bfe8a5e12034335b1f
Gerrit-Change-Number: 9009
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jan 2018 19:10:47 +0000
Gerrit-HasComments: Yes

Reply via email to