Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 )
Change subject: IMPALA-5440 Add planner tests with extreme statistics values ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9065/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9065/2//COMMIT_MSG@8 PS2, Line 8: the jira suggests focusing on several extreme value issues. pls state which ones are addressed with this patch. http://gerrit.cloudera.org:8080/#/c/9065/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/9065/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@507 PS2, Line 507: remove whitespace http://gerrit.cloudera.org:8080/#/c/9065/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@509 PS2, Line 509: Cardinality perhaps rename to testCardinalityBounds ? ... in general, there could be other aspects of cardinality that one would want to test. http://gerrit.cloudera.org:8080/#/c/9065/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@510 PS2, Line 510: value perhaps rephrase as: Tests that cardinality estimates do not overflow. http://gerrit.cloudera.org:8080/#/c/9065/2/testdata/workloads/functional-planner/queries/PlannerTest/cardinality.test File testdata/workloads/functional-planner/queries/PlannerTest/cardinality.test: http://gerrit.cloudera.org:8080/#/c/9065/2/testdata/workloads/functional-planner/queries/PlannerTest/cardinality.test@1 PS2, Line 1: # Test cardinality overflow. other cardinalities to consider starting with are 0 (no rows) and negative cardinalities (not sure if we allow them to be specified in the first place). I see that alex has several suggestions in the jira via query options to also consider. -- To view, visit http://gerrit.cloudera.org:8080/9065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86dec47cf1438882cafaec53e97864ccfcdff3cb Gerrit-Change-Number: 9065 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Thu, 18 Jan 2018 22:37:46 +0000 Gerrit-HasComments: Yes
