Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 )
Change subject: IMPALA-5440 Add planner tests with extreme statistics values ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/9065/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9065/6//COMMIT_MSG@8 PS6, Line 8: pls update this as mentioned in a prior comment. http://gerrit.cloudera.org:8080/#/c/9065/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/9065/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@514 PS5, Line 514: makes nit: "... this test guards against the cardinality overflowing." similar suggestion for the test descriptions below as well. http://gerrit.cloudera.org:8080/#/c/9065/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@562 PS5, Line 562: Preconditions any reason this check is here? http://gerrit.cloudera.org:8080/#/c/9065/6/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/9065/6/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@514 PS6, Line 514: makes cardinality overflow nit: ... this test guards against the cardinality estimate overflowing. similar suggestion for tests below http://gerrit.cloudera.org:8080/#/c/9065/6/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@528 PS6, Line 528: _VIA_STATS_TASK'='true',"; : Table tbl = addTestTable("CREATE EXTERNAL TABLE tpch.ex_customer_cardinality_over long lines. pls keep them <= 90. http://gerrit.cloudera.org:8080/#/c/9065/6/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@562 PS6, Line 562: Preconditions why is this check here? http://gerrit.cloudera.org:8080/#/c/9065/6/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: http://gerrit.cloudera.org:8080/#/c/9065/6/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@785 PS6, Line 785: Boolean zeroCardinality) t long lines -- To view, visit http://gerrit.cloudera.org:8080/9065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86dec47cf1438882cafaec53e97864ccfcdff3cb Gerrit-Change-Number: 9065 Gerrit-PatchSet: 6 Gerrit-Owner: [email protected] Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Tue, 30 Jan 2018 00:34:22 +0000 Gerrit-HasComments: Yes
