Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 )
Change subject: IMPALA-5440 Add planner tests with extreme statistics values ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9065/2/testdata/workloads/functional-planner/queries/PlannerTest/cardinality.test File testdata/workloads/functional-planner/queries/PlannerTest/cardinality.test: http://gerrit.cloudera.org:8080/#/c/9065/2/testdata/workloads/functional-planner/queries/PlannerTest/cardinality.test@5 PS2, Line 5: | Per-Host Resources: mem-estimate=0B mem-reservation=0B I generally don't think this is the right way to approach this kind of testing. Adding more .test files especially at higher explain levels makes future changes harder. I think it makes most sense to write code to walk the plan and check that the cardinality is within legal bounds. The purpose of this testing is mostly to guard against regressions where query panning fails or produces nonsensical cardinalities (see IMPALA-5282 for the original motivation of adding these tests). -- To view, visit http://gerrit.cloudera.org:8080/9065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86dec47cf1438882cafaec53e97864ccfcdff3cb Gerrit-Change-Number: 9065 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Fri, 19 Jan 2018 17:59:31 +0000 Gerrit-HasComments: Yes
