Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 )
Change subject: IMPALA-5440 Add planner tests with extreme statistics values ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@522 PS3, Line 522: from tpch.lineitem a, tpch.lineitem b, tpch.lineitem c"; : checkCardinalityBounds(query, "t what is this testing? http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@526 PS3, Line 526: nion select * from tpch.lineitem b " : + "union select * from tpch.lineitem is this expected to overflow? perhaps feed in large number of rows. http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@532 PS3, Line 532: h.lineitem.l_o is this supposed to overflow? http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@536 PS3, Line 536: tpch.lineitem" is this supposed to overflow? perhaps mention the operator that this is testing (exchange?) http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@788 PS3, Line 788: pls add comments. http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@792 PS3, Line 792: execRequest == null) : return; single line http://gerrit.cloudera.org:8080/#/c/9065/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@802 PS3, Line 802: e.estimated_stats.ca is this guaranteed to be non-null? -- To view, visit http://gerrit.cloudera.org:8080/9065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86dec47cf1438882cafaec53e97864ccfcdff3cb Gerrit-Change-Number: 9065 Gerrit-PatchSet: 3 Gerrit-Owner: [email protected] Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Wed, 24 Jan 2018 02:22:59 +0000 Gerrit-HasComments: Yes
