Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 )
Change subject: IMPALA-6193: Track memory of incoming data streams ...................................................................... Patch Set 11: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/exec-env.cc@332 PS11, Line 332: // deferred RPC calls. buffered in the stream manager http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/krpc-data-stream-mgr.h File be/src/runtime/krpc-data-stream-mgr.h: http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/krpc-data-stream-mgr.h@294 PS11, Line 294: /// specific receiver. Not owned. Used only to track payloads of deferred RPCs (e.g. early senders) http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/krpc-data-stream-mgr.h@299 PS11, Line 299: the service The wording seems a bit confusing. It sounds as if DataStreamService is transferring memory to itself. So may help to clarify what service here means. How about replacing "the service" with "datastream mgr / receiver" ? -- To view, visit http://gerrit.cloudera.org:8080/8914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df1204d2483313a8a18e5e3be6cec9e402614c4 Gerrit-Change-Number: 8914 Gerrit-PatchSet: 11 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2018 19:17:48 +0000 Gerrit-HasComments: Yes
