Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8914 )

Change subject: IMPALA-6193: Track memory of incoming data streams
......................................................................


Patch Set 13: Code-Review+2

(1 comment)

Rebased the change, carrying Michael's +2.

http://gerrit.cloudera.org:8080/#/c/8914/7/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/8914/7/be/src/runtime/exec-env.cc@343
PS7, Line 343:         new MemTracker(-1, "Data Stream Queued RPC Calls", 
mem_tracker_.get()));
             :     RETURN_IF_ERROR(KrpcStreamMgr()->Init(stream_mgr_tracker, 
data_svc_tracker));
             :
             :     unique_ptr<ServiceIf> data_svc(new 
DataStreamService(rpc_mgr_.get()));
             :     i
> Thanks for the heads up, I'll double check.
Double checked that they are removed.



--
To view, visit http://gerrit.cloudera.org:8080/8914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2df1204d2483313a8a18e5e3be6cec9e402614c4
Gerrit-Change-Number: 8914
Gerrit-PatchSet: 13
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Sat, 27 Jan 2018 02:28:20 +0000
Gerrit-HasComments: Yes

Reply via email to