Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 )
Change subject: IMPALA-6193: Track memory of incoming data streams ...................................................................... Patch Set 11: (3 comments) Thanks for the review. I addressed the remaining comments in PS12 and will rebase the change next. http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/exec-env.cc@332 PS11, Line 332: // deferred RPC calls. > buffered in the stream manager Done, though I'm not entirely sure whether I captured your intent correctly. http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/krpc-data-stream-mgr.h File be/src/runtime/krpc-data-stream-mgr.h: http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/krpc-data-stream-mgr.h@294 PS11, Line 294: /// specific receiver. Not owned. > Used only to track payloads of deferred RPCs (e.g. early senders) Done http://gerrit.cloudera.org:8080/#/c/8914/11/be/src/runtime/krpc-data-stream-mgr.h@299 PS11, Line 299: the service > The wording seems a bit confusing. It sounds as if DataStreamService is tra Done -- To view, visit http://gerrit.cloudera.org:8080/8914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df1204d2483313a8a18e5e3be6cec9e402614c4 Gerrit-Change-Number: 8914 Gerrit-PatchSet: 11 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 27 Jan 2018 01:58:24 +0000 Gerrit-HasComments: Yes
