David Knupp has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9385 )

Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME 
has spaces
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@23
PS2, Line 23: if [[ ( "'$PWD'" =~ [[:blank:]] ) || ("'$IMPALA_HOME'" =~ 
[[:blank:]] ) ]]
I guess I was specifically wondering if this would work:

  [...]

  ROOT=`dirname "$0"`
  ROOT=`cd "$ROOT" >/dev/null; pwd`

  if [[ ("'$ROOT'" =~ [[:blank:]]) ]]   # do we need a semi-colon here?
  then
    echo "IMPALA_HOME cannot have spaces in the path"
    exit 1
  fi

  [...]

  export IMPALA_HOME="$ROOT"


http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@25
PS2, Line 25: Excuting directory/IMPALA_HOME
"Executing"? Though I'm actually not sure how this whole line is supposed to 
read. What about just "export IMPALA_HOME="$ROOT""?



--
To view, visit http://gerrit.cloudera.org:8080/9385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81
Gerrit-Change-Number: 9385
Gerrit-PatchSet: 2
Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:27:08 +0000
Gerrit-HasComments: Yes

Reply via email to