Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 )
Change subject: IMPAL-4430: Update build scripts to die hard when IMPALA_HOME has spaces ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9385/2/buildall.sh@23 PS2, Line 23: if [[ ( "'$PWD'" =~ [[:blank:]] ) || ("'$IMPALA_HOME'" =~ [[:blank:]] ) ]] > I guess I was specifically wondering if this would work: Yes. This should work since it checks $ROOT to not have space which is then used as IMPALA_HOME But this might need to be moved before the trap statement to ensure PWD , ROOT and IMPALA_HOME are same -- To view, visit http://gerrit.cloudera.org:8080/9385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08b3d2b3f3e14c568d1672ee86ff2c52e8017b81 Gerrit-Change-Number: 9385 Gerrit-PatchSet: 2 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 20:37:09 +0000 Gerrit-HasComments: Yes
