Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 )
Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9381/3/be/src/exec/parquet-column-stats.inline.h File be/src/exec/parquet-column-stats.inline.h: http://gerrit.cloudera.org:8080/#/c/9381/3/be/src/exec/parquet-column-stats.inline.h@29 PS3, Line 29: template <typename T, typename Enable = void> > nit: Shouldn't these live inside either ColumnStats or somewhere in util di Yeah, probably it is not the best place for them. ColumnStats is a template class and putting it there would be confusing I think. Maybe I could nest it inside ColumnStatsBase. Anyway, I found an unused header in the util dir called stat-util.h, I moved the definitions there for now. http://gerrit.cloudera.org:8080/#/c/9381/1/be/src/exec/parquet-column-stats.inline.h File be/src/exec/parquet-column-stats.inline.h: http://gerrit.cloudera.org:8080/#/c/9381/1/be/src/exec/parquet-column-stats.inline.h@37 PS1, Line 37: std::is_floating_point<T>::value> > Thanks for checking and for the explanations. you're welcome! http://gerrit.cloudera.org:8080/#/c/9381/1/testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test File testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test: http://gerrit.cloudera.org:8080/#/c/9381/1/testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test@507 PS1, Line 507: select * from test_nan where val < 100 > nit: . added . here, and also to some other sentences. -- To view, visit http://gerrit.cloudera.org:8080/9381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3957806948f7c661af4be5495f2ec92d1e9fc9d6 Gerrit-Change-Number: 9381 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Feb 2018 11:31:53 +0000 Gerrit-HasComments: Yes
