Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 )
Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics ...................................................................... Patch Set 5: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/9381/1/be/src/exec/parquet-column-stats.inline.h File be/src/exec/parquet-column-stats.inline.h: http://gerrit.cloudera.org:8080/#/c/9381/1/be/src/exec/parquet-column-stats.inline.h@37 PS1, Line 37: > If you prefer, you can use Yes, it is also a viable approach, however I'd stick with the current solution because of the followings: * more concise * fewer enable_ifs * decltype(auto) chooses the right return type we need, and I think it is more readable as well http://gerrit.cloudera.org:8080/#/c/9381/4/be/src/util/stat-util.h File be/src/util/stat-util.h: http://gerrit.cloudera.org:8080/#/c/9381/4/be/src/util/stat-util.h@29 PS4, Line 29: template <typename T> > I think this would be better placed in some parquet-specific files since it Yeah I agree, btw ColumnStatsBase was my other candidate as well. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/9381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3957806948f7c661af4be5495f2ec92d1e9fc9d6 Gerrit-Change-Number: 9381 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 02 Mar 2018 20:08:46 +0000 Gerrit-HasComments: Yes
