Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 )
Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9381/1/be/src/exec/parquet-column-stats.inline.h File be/src/exec/parquet-column-stats.inline.h: http://gerrit.cloudera.org:8080/#/c/9381/1/be/src/exec/parquet-column-stats.inline.h@37 PS1, Line 37: std::is_floating_point<T>::value> > you're welcome! If you prefer, you can use template<typename T> const std::enable_if_t<!std::is_floating_point<T>{}, T> & Bigger(const T& x, const T& y) { return std::max(x, y); } template<typename T> std::enable_if_t<std::is_floating_point<T>{}, T> Bigger(T x, T y) { return std::fmax(x, y); } -- To view, visit http://gerrit.cloudera.org:8080/9381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3957806948f7c661af4be5495f2ec92d1e9fc9d6 Gerrit-Change-Number: 9381 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 24 Feb 2018 19:12:55 +0000 Gerrit-HasComments: Yes
