Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 )
Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9381/4/be/src/util/stat-util.h File be/src/util/stat-util.h: http://gerrit.cloudera.org:8080/#/c/9381/4/be/src/util/stat-util.h@29 PS4, Line 29: struct MinMaxTrait { I think this would be better placed in some parquet-specific files since it is the min/max ordering we use for parquet files. The other function in stat-util looks like it's for things to compute statistical values. My preference would be to have it as a class member of ColumnStatsBase. -- To view, visit http://gerrit.cloudera.org:8080/9381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3957806948f7c661af4be5495f2ec92d1e9fc9d6 Gerrit-Change-Number: 9381 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Feb 2018 17:15:49 +0000 Gerrit-HasComments: Yes
