Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9274/4/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/9274/4/buildall.sh@320 PS4, Line 320: export LZ4_VERSION=1.7.5 Remind me what happens if these end up inconsistent with other _VERSIONs from other components? It looks to me like they all match now. http://gerrit.cloudera.org:8080/#/c/9274/4/source/orc/build.sh File source/orc/build.sh: http://gerrit.cloudera.org:8080/#/c/9274/4/source/orc/build.sh@38 PS4, Line 38: DBUILD_LZ4 Even though compression BUILDs are OFF, we still need to specify what version is needed? http://gerrit.cloudera.org:8080/#/c/9274/4/source/orc/orc-1.4.3-patches/0001-Allow-building-against-external-versions-of-dependen.patch File source/orc/orc-1.4.3-patches/0001-Allow-building-against-external-versions-of-dependen.patch: http://gerrit.cloudera.org:8080/#/c/9274/4/source/orc/orc-1.4.3-patches/0001-Allow-building-against-external-versions-of-dependen.patch@4 PS4, Line 4: PATCH 1/2 What is part 2/2? Also, is there a JIRA for this? Is it slated to land upstream? -- To view, visit http://gerrit.cloudera.org:8080/9274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e Gerrit-Change-Number: 9274 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 06 Mar 2018 18:13:35 +0000 Gerrit-HasComments: Yes
